Expose ldap pool active parameter to limit retries #274
Conversation
Currently the pool is initiated so that servers are retried indefinetely. This makes it hard to define concrete hard timeout for login operation. This change exposes ldap3's ServerPool active parameter as setting. That way it provides means to resolve situations as with etianen#264. https://ldap3.readthedocs.io/en/latest/server.html#server-pool
|
Thanks for this! Do you think it might be best to make the new default 1, rather than |
|
Released as 0.15.7 ❤️ |
I intend to put Maybe @hho6643 can chime in? Note that the same is valid for the rest of pool arguments. I can extend this patch to make them configurable as well if you think this is of any value. |
|
Hi - it wasn’t an intentional decision. Having a timeout is an improvement IMHO. And it looks like it’s already merged so 👍 |
Currently the pool is initiated so that servers are retried indefinetely. This makes it hard to define concrete hard timeout for login operation.
This change exposes ldap3's ServerPool active parameter as setting. That way it provides means to resolve situations as with #264.
Based on the following docs: https://ldap3.readthedocs.io/en/latest/server.html#server-pool